Android build without AngleScript and Lua

extobias · November 24, 2020, 12:23am

Hi there,
I’m trying to build a just cloned copy from the repository but without Angelscript and LUA, but it’s not working, its compiling ThirdParty/AngelScript and ThirdParty\LuaJIT. It used to work with the command

gradlew.bat -P ANDROID_ABI=arm64-v8a -P URHO3D_ANGELSCRIPT=0 -P URHO3D_PCH=0 -P URHO3D_WEBP=0 -P URHO3D_LUA=0 -P URHO3D_LUAJIT=0 build

Also I’ve added URHO3D_LUAJIT_AMALG=0 but the result it’s the same.
I’m missing something?
Cheers

Modanung · November 24, 2020, 9:58am

Try prefixing -D to the flags. Or is -P gradle logix? #gradle-to-crave

Dry has Lua and D3D ripped out - and shorter flag names, naturally - seems like you wouldn’t miss either.

Although you are in bat country.

extobias · November 24, 2020, 1:56pm

From doc https://urho3d.github.io/documentation/HEAD/_building.html#Building_Android

The Gradle properties can be passed by using “-P” Gradle option, e.g.: “./gradlew -P URHO3D_LUA=0 build” to build without Lua subsystem

wait @weitjong is out too?

extobias · November 25, 2020, 9:47pm

I think only environment variables are taken by the new build system.
Is this deliberately removed? I could submit a PR (based on previous versions of the file) to support again command line options

WangKai · November 26, 2020, 3:19am

Hi,

I think you can change these parameters to apply the build flags ( e.g. -D URHO3D_LUA=0):

github.com

urho3d/Urho3D/blob/eb0e7677f67296a318fa7ad3404b43a20b2cfdd0/android/urho3d-lib/build.gradle.kts#L51


compileSdkVersion(30)
defaultConfig {
    minSdkVersion(18)
    targetSdkVersion(30)
    versionCode = 1
    versionName = project.version.toString()
    testInstrumentationRunner = "android.support.test.runner.AndroidJUnitRunner"
    externalNativeBuild {
        cmake {
            arguments.apply {
                System.getenv("ANDROID_CCACHE")?.let { add("-D ANDROID_CCACHE=$it") }
                // Pass along matching env-vars as CMake build options
                addAll(project.file("../../script/.build-options")
                    .readLines()
                    .mapNotNull { variable -> System.getenv(variable)?.let { "-D $variable=$it" } }
                )
            }
            targets.add("Urho3D")
        }
    }
    splits {

github.com

urho3d/Urho3D/blob/eb0e7677f67296a318fa7ad3404b43a20b2cfdd0/android/launcher-app/build.gradle.kts#L48


minSdkVersion(18)
targetSdkVersion(30)
applicationId = "io.urho3d.launcher"
versionCode = 1
versionName = project.version.toString()
testInstrumentationRunner = "android.support.test.runner.AndroidJUnitRunner"
externalNativeBuild {
    cmake {
        arguments.apply {
            System.getenv("ANDROID_CCACHE")?.let { add("-D ANDROID_CCACHE=$it") }
            add("-D BUILD_STAGING_DIR=${findProject(":android:urho3d-lib")!!.projectDir}/$buildStagingDir")
            add("-D URHO3D_PLAYER=1")
            // Skip building samples for 'STATIC' lib type to reduce the spacetime requirement
            add("-D URHO3D_SAMPLES=${if (System.getenv("URHO3D_LIB_TYPE") == "SHARED") "1" else "0"}")
            // Pass along matching env-vars as CMake build options
            addAll(project.file("../../script/.build-options")
                .readLines()
                .filterNot { listOf("URHO3D_PLAYER", "URHO3D_SAMPLES").contains(it) }
                .mapNotNull { variable -> System.getenv(variable)?.let { "-D $variable=$it" } }
            )
        }

Hope it helps!

extobias · November 26, 2020, 2:19pm

Yes, you’re right but by this way options are hardcoded in the build file. Before you could pass this options through command line.

WangKai · November 26, 2020, 4:05pm

I didn’t try but I think you can try to modify the scripts to achive this-

extobias · November 26, 2020, 5:56pm

I’ve found a way with previous build files and submit a PR. Still it would be nice to know why this changes were deliberately removed. Thanks anyway.

dertom · November 26, 2020, 6:34pm

when I see it right all you need to do is to export the cmake-options as environment-variable.

In liinux:

export URHO3D_ANGELSCRIPT=0

I guess in win (not sure ):

set URHO3D_ANGELSCRIPT=0

And then call gradlew

ps: for me to compile the example at all I had to set URHO3D_LIB_TYPE=SHARED

weitjong · November 29, 2020, 2:05am

Sorry for late answer. In the last Gradle build system refactoring I have decided to remove the support for using “-P” to pass through the build option in order to simplify the build script and to reduce the possibility of conflict. The documentation file has been updated accordingly. If you guys ever look at the commit itself, you know it is intentional. Note that the site is no longer updated automatically anymore.

Using “rake” command, the build option can be passed like this:

$ rake URHO3D_LIB_TYPE=SHARED URHO3D_ANGELSCRIPT=0 PLATFORM=android

It works on all host systems with Ruby/Rake installed. The last PLATFORM env-var is not needed when the command is invoked inside a running Android DBE docker container.

It is also possible to use “gradlew” directly like this:

$ URHO3D_LIB_TYPE=SHARED URHO3D_ANGELSCRIPT=0 ./gradlew build

However, this won’t work on Windows. You may have to create a simple wrapper yourself to set the env-var before invoking gradlew.

extobias · November 29, 2020, 12:32pm

That’s ok, I didn’t know that the doc page doesn’t update anymore, so I thought that you can still pass the options from the list. Well I guess that if it was intentionally removed we have revert the PR

dertom · November 30, 2020, 11:44am

The problem is that the docs of 1.7.1 are shown as default (can we change this somehow?). You need to set this to ‘HEAD’ (to be honest, I also struggled with that)

extobias · November 30, 2020, 1:26pm

In HEAD still says that you have a list of supported Gradle properties.

weitjong · December 4, 2020, 2:46am

Slightly off-topic and for those who has not keep track of all the recent threads. The migration from Travis CI to GitHub Action CI/CD was kind of being rushed. The new CI/CD workflow has not reached the feature parity with the old one yet when I made the cut over. The site documentation update is one of the thing missing. There are people trying to play “politic” in this project. May be not the best way to describe it but I have lost interest to complete what I have started. So, let the project die slowly and let those people happy.

Modanung · December 4, 2020, 11:39am

Let's run...

extobias · December 4, 2020, 8:10pm

Sad news indeed, but somehow you could see it coming. There is anywhere some doc about the features missing in the new workflow? Just in case that someday someone want to take the lead.
And @weitjong thanks for your contribution.

weitjong · December 5, 2020, 3:01am

There is no roadmap nor migration plan. In fact I didn’t even know how to do GitHub Actions workflow a few months back when I started, the main reason I did it is simply to learn new skill for myself. Anyway, one can just compare between the old Rakefile and the new rakefile to spot any missing logic not yet migrated over. It is an apple to orange comparison though as the underlying design has changed.