Pull requests pilling up

I don’t mean to criticize anyone, just to better understand the current state of affairs.

Pull requests seem to be piling up. Is it because there isn’t enough manpower to review them? Is it a diplomatic way to reject them? Is it some decision-making orphanage creeping in after @cadaver stepped down?

(Again, not trying to pick a fight with anyone, just interested.)

Disclosure: I am an interested party, waiting on a PR that I made ~1 month ago after indication it could be a useful if humble addition (but PRs are contributions, so hopefully any user is potentially an interested party :slight_smile: )

2 Likes

Personally if i see a PR that I don’t want to see it merged then I would try to shoot it down immediately. So, you can consider those that remain have at least passed the first casual/visual review and have a good chance to be merged or have merits for further discussion even if they don’t make it at the end. However, until one of the core team member (which effectively only left with me and Eugene active lately) has the free time to actually review and/or try the code, they will remain stuck there for a while. I don’t know about others but my excuse is having to take turn to take care of my autistic daughter who just gone through multi-stage eye surgeries, so when I still choose to spend some of my remaining free time for Urho then I actually do it for my own pleasure and not for pressure, tending to pick those that I have interest and are easier for me.

You are also right to point out that the rate of merging slows down after Lasse stepped down from lead role. None of us have the same level of insight of the engine to review and merge the PR as efficient as him even when we have all the time it needs. This is the consequence of losing someone that important to the project. But rest assured all the core team members have a license to kill or merge a PR on their own. Personally I would rather be on the slow side to ensure those newly merged code has the same standard as the rest.

If you still have faith to the project then don’t let this, hopefully, temporary situation to stop you. And if you have more things to contribute, send them in as PR. We need to replenish our ranks and we use those PRs to identify the new candidate.

4 Likes

I want to remind that what I did, particularly in the last year of me being the lead, I usually just let the code in with minimal review. Not sure that was the best either, though it was expedient.

1 Like

Thanks for the reply @weitjong. I am very sorry about such hardship. I hope your daughter heals smoothly and quickly.

I totally get that you and @Eugene do what you do freely and should not be pressed to do more. Nevertheless, I wonder if there would be a way to take advantage of community collaboration to share the burden though. For instance, if people were encouraged to do code reviews on PRs, that could actually improve the code that went in and it might be a way to share the technical part of the effort while leaving the actual decision to you. Core team members would keep the reigns and not be bound by anyone’s opinion, just have the benefit of some kind of peer review to help (if they chose to credit them). That might stir things a bit and help ward off stagnation.

I don’t know, it is just a suggestion… I have no idea if anyone in the community would play along with it. You are the ones in the best position to judge if something like that could actually help while minimizing unnecessary turbulence… food for thought.